Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: revert low space threshold hard limit (#2864) #2875

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2864 to release-4.0


What problem does this PR solve?

The previous PR uses a hard limit for low space. If the capacity beyond 500G, it will use 100G as its low space threshold. It doesn't seem reasonable.

What is changed and how it works?

This PR changes back to the original way to control low space.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Change back to the original way to control the low space threshold

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 1, 2020
@disksing
Copy link
Contributor

disksing commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #2875 into release-4.0 will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2875      +/-   ##
===============================================
- Coverage        77.37%   77.37%   -0.01%     
===============================================
  Files              208      208              
  Lines            22765    22762       -3     
===============================================
- Hits             17615    17612       -3     
+ Misses            3822     3816       -6     
- Partials          1328     1334       +6     
Impacted Files Coverage Δ
server/core/store.go 80.12% <100.00%> (-0.19%) ⬇️
server/member/leader.go 71.20% <0.00%> (-1.95%) ⬇️
server/tso/tso.go 78.48% <0.00%> (-1.90%) ⬇️
server/region_syncer/client.go 85.40% <0.00%> (-1.46%) ⬇️
server/server.go 76.37% <0.00%> (-0.75%) ⬇️
client/base_client.go 90.60% <0.00%> (-0.68%) ⬇️
server/schedule/operator_controller.go 81.41% <0.00%> (+0.16%) ⬆️
pkg/btree/btree.go 87.65% <0.00%> (+0.80%) ⬆️
server/schedulers/adjacent_region.go 76.59% <0.00%> (+1.06%) ⬆️
pkg/mock/mockhbstream/mockhbstream.go 90.76% <0.00%> (+1.53%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 928c257...020332e. Read the comment docs.

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2020
@disksing disksing merged commit 6403e70 into tikv:release-4.0 Sep 1, 2020
@disksing disksing deleted the release-4.0-df2344f251ce branch September 1, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants