Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update pingcap/log to support json formatted log (#2563) #2565

Merged
merged 4 commits into from
Jul 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2563 to release-4.0


What problem does this PR solve?

fix #2562

What is changed and how it works?

update the log package to the latest can solve the issue.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    config the log format to json, check the output

Related changes

Release note

Support json formatted log

@ti-srebot
Copy link
Contributor Author

@zz-jason please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2020

Codecov Report

Merging #2565 into release-4.0 will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2565      +/-   ##
===============================================
+ Coverage        77.13%   77.21%   +0.07%     
===============================================
  Files              205      205              
  Lines            22129    22129              
===============================================
+ Hits             17070    17086      +16     
+ Misses            3756     3743      -13     
+ Partials          1303     1300       -3     
Impacted Files Coverage Δ
pkg/dashboard/adapter/manager.go 86.79% <0.00%> (-6.61%) ⬇️
server/kv/etcd_kv.go 84.41% <0.00%> (-3.90%) ⬇️
server/cluster/coordinator.go 74.52% <0.00%> (-2.20%) ⬇️
server/server.go 76.94% <0.00%> (+0.15%) ⬆️
server/cluster/cluster.go 80.87% <0.00%> (+0.21%) ⬆️
server/tso/tso.go 81.75% <0.00%> (+0.72%) ⬆️
pkg/btree/btree.go 87.65% <0.00%> (+0.80%) ⬆️
server/core/storage.go 75.20% <0.00%> (+0.82%) ⬆️
server/grpc_service.go 60.23% <0.00%> (+1.15%) ⬆️
pkg/mock/mockhbstream/mockhbstream.go 90.76% <0.00%> (+1.53%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd6bbd...173f490. Read the comment docs.

@nolouch nolouch removed this from the v4.0.2 milestone Jun 21, 2020
@nolouch
Copy link
Contributor

nolouch commented Jun 21, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @nolouch, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@HunDunDM HunDunDM added this to the v4.0.3 milestone Jun 22, 2020
@disksing
Copy link
Contributor

disksing commented Jul 1, 2020

/merge

1 similar comment
@HunDunDM
Copy link
Member

HunDunDM commented Jul 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 2, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@HunDunDM
Copy link
Member

HunDunDM commented Jul 2, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 2, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@HunDunDM
Copy link
Member

HunDunDM commented Jul 3, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 9f79697 into tikv:release-4.0 Jul 3, 2020
@lhy1024 lhy1024 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants