Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: return 404 when scheduler is not found #2328

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 3, 2020

What problem does this PR solve?

Fixes #2319.

What is changed and how it works?

This PR returns 404 when the scheduler/scheduler config is not found.

Release note

Fix the problem that returns 500 when the scheduler is not found

Check List

Tests

  • Unit test

Code changes

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/api HTTP API. label Apr 3, 2020
@rleungx rleungx added this to the v4.0.0-ga milestone Apr 3, 2020
@rleungx rleungx requested review from nolouch and disksing April 3, 2020 11:06
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Apr 3, 2020
@nolouch nolouch removed the contribution This PR is from a community contributor. label Apr 4, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Apr 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

Your auto merge job has been accepted, waiting for 2318

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

@rleungx merge failed.

@rleungx
Copy link
Member Author

rleungx commented Apr 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

@rleungx merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Apr 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit 635f1ce into tikv:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP status code is wrong when deleting non-exist scheduler
4 participants