schedule, schedulers: make schedulers aware of placement rules #1999
Conversation
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #1999 +/- ##
==========================================
+ Coverage 76.83% 76.88% +0.04%
==========================================
Files 183 183
Lines 18301 18323 +22
==========================================
+ Hits 14062 14088 +26
+ Misses 3175 3172 -3
+ Partials 1064 1063 -1
Continue to review full report at Codecov.
|
server/schedulers/hot_region.go
Outdated
| srcPeer := srcRegion.GetStorePeer(srcStoreID) | ||
| if srcPeer == nil { | ||
| return nil, nil, nil, Influence{} | ||
| } |
There was a problem hiding this comment.
why need to judge it in hot region rather than other schedulers?
There was a problem hiding this comment.
Why not use continue to just skip this peer?
There was a problem hiding this comment.
@shafreeck good idea.
There was a problem hiding this comment.
@lhy1024 because hot region scheduler selects region from stats, which may be out of date. Others do not have this problem.
There was a problem hiding this comment.
@lhy1024 For shcedulers that include label related tests (hotWrite and shuffleHot), I have changed them to test twice, the second time run with placement rules enabled.
Signed-off-by: disksing <i@disksing.com>
|
PTAL @rleungx @shafreeck |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
…1999) Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Make schedulers aware of placement rules.
What is changed and how it works?
When placement rule is enabled, use
RuleFilterinstead ofDistinctScoreFilter.