Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: support create with context #1994

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Dec 6, 2019

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Cherry-pick #1993

What is changed and how it works?

add NewClientWithContext

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release notes

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/client Client logic. label Dec 6, 2019
@disksing disksing added this to the v3.0.7 milestone Dec 6, 2019
@rleungx
Copy link
Member

rleungx commented Dec 6, 2019

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1994 into release-3.0 will increase coverage by 0.2%.
The diff coverage is 90%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0    #1994     +/-   ##
==============================================
+ Coverage        69.32%   69.52%   +0.2%     
==============================================
  Files              170      170             
  Lines            16757    16764      +7     
==============================================
+ Hits             11616    11655     +39     
+ Misses            4157     4136     -21     
+ Partials           984      973     -11
Impacted Files Coverage Δ
client/client.go 73.81% <90%> (+2.57%) ⬆️
server/schedulers/random_merge.go 62.5% <0%> (-5%) ⬇️
server/namespace_cluster.go 81.81% <0%> (-3.9%) ⬇️
server/cluster.go 81.72% <0%> (-0.51%) ⬇️
server/handler.go 52.11% <0%> (+0.49%) ⬆️
server/grpc_service.go 59.27% <0%> (+0.63%) ⬆️
server/tso.go 76.59% <0%> (+2.12%) ⬆️
server/leader.go 82.04% <0%> (+2.85%) ⬆️
server/util.go 75.15% <0%> (+7%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88372a...6e39e31. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 6, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2019

Your auto merge job has been accepted, waiting for 1995

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3eb5be2 into tikv:release-3.0 Dec 6, 2019
@disksing disksing modified the milestones: v3.0.7, v3.0.8 Dec 20, 2019
@disksing disksing deleted the clientctx3.0 branch March 19, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants