Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters: add rule filters #1917

Merged
merged 6 commits into from
Nov 14, 2019
Merged

filters: add rule filters #1917

merged 6 commits into from
Nov 14, 2019

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Nov 8, 2019

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

continue merging placement rules.

What is changed and how it works?

  • labelConstraintFilter: selects stores satisfy the constraints.
  • ruleFitFilter: make sure after replacing a peer, isolation level does not decrease.

Check List

Tests

  • Unit test

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/schedule Scheduling logic. label Nov 8, 2019
@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #1917 into master will increase coverage by 0.13%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1917      +/-   ##
==========================================
+ Coverage   77.96%   78.09%   +0.13%     
==========================================
  Files         167      167              
  Lines       16613    16645      +32     
==========================================
+ Hits        12952    12999      +47     
+ Misses       2661     2649      -12     
+ Partials     1000      997       -3
Impacted Files Coverage Δ
server/core/region_option.go 84.82% <100%> (+0.7%) ⬆️
server/schedule/filter/filters.go 75.43% <70.37%> (-0.67%) ⬇️
pkg/testutil/operator_check.go 88.88% <0%> (-11.12%) ⬇️
server/tso/tso.go 76.11% <0%> (-6.72%) ⬇️
pkg/etcdutil/etcdutil.go 88.4% <0%> (ø) ⬆️
server/server.go 83.47% <0%> (+0.41%) ⬆️
server/config/option.go 93.02% <0%> (+0.93%) ⬆️
server/core/storage.go 76.04% <0%> (+1.19%) ⬆️
server/grpc_service.go 58.62% <0%> (+1.29%) ⬆️
server/member/leader.go 79.59% <0%> (+2.55%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d08d9...41fe623. Read the comment docs.

Signed-off-by: disksing <i@disksing.com>
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

server/schedule/filter/filters.go Show resolved Hide resolved
server/schedule/filter/filters.go Show resolved Hide resolved
Signed-off-by: disksing <i@disksing.com>
@nolouch nolouch added the priority/P1 The issue has P1 priority. label Nov 13, 2019
server/schedule/filter/filters.go Show resolved Hide resolved
@disksing
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

Your auto merge job has been accepted, waiting for 1918

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

@disksing merge failed.

@disksing
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

@disksing merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 13, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

@disksing merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Nov 13, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

Your auto merge job has been accepted, waiting for 1903

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 13, 2019

@disksing merge failed.

@disksing
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 14, 2019

/run-all-tests

@sre-bot sre-bot merged commit 5b831f6 into tikv:master Nov 14, 2019
@disksing disksing deleted the placement11 branch November 14, 2019 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. priority/P1 The issue has P1 priority. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants