opt, schedulers: consider placement rules when verify region healthy #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
shafreeck
reviewed
Nov 6, 2019
| region.learners = learners | ||
| peers := region.meta.GetPeers() | ||
| for i := range peers { | ||
| for _, l := range learners { |
There was a problem hiding this comment.
Just mention it, why not try to keep the same style of the loop like for j := range learners, then use learners[j] later instead.
There was a problem hiding this comment.
only because l is shorter than learners[j].
lhy1024
reviewed
Nov 6, 2019
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
/run-all-tests |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
continue merging placement rules.
What is changed and how it works?
core.RegionHealthwithopt.RegionHealth. When placement rules is enabled, it allows learner peers.core.RegionHealthAllowPendingwithopt.RegionHealthAllowPending. When placement rules is enabled, it allows learner peers.len(region.GetPeers()) == cluster.GetMaxReplicas()withopt.IsRegionReplicated. When placement rules is enabled, it checks if peers can fit rules.Check List
Tests