Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: add manager and FitRegion interface #1865

Merged
merged 7 commits into from
Nov 4, 2019

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Continue merging placement rules.

What is changed and how it works?

  • add RuleManager container
  • add FitRegion interface.

Check List

Tests

  • Unit test

Code changes

  • Has persistent data change

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/schedule Scheduling logic. label Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1865 into master will decrease coverage by 0.02%.
The diff coverage is 63.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
- Coverage   77.94%   77.91%   -0.03%     
==========================================
  Files         161      163       +2     
  Lines       16076    16279     +203     
==========================================
+ Hits        12530    12684     +154     
- Misses       2551     2596      +45     
- Partials      995      999       +4
Impacted Files Coverage Δ
server/cluster.go 83.1% <0%> (-0.13%) ⬇️
pkg/mock/mockcluster/mockcluster.go 89.58% <0%> (-0.63%) ⬇️
server/schedule/placement/fit.go 0% <0%> (ø)
server/schedule/placement/rule_manager.go 85.43% <85.43%> (ø)
server/region_syncer/client.go 77.63% <0%> (-7.9%) ⬇️
server/schedulers/random_merge.go 58.13% <0%> (-4.66%) ⬇️
server/member/leader.go 75.51% <0%> (-3.07%) ⬇️
client/client.go 68.6% <0%> (-1.73%) ⬇️
server/grpc_service.go 58.62% <0%> (-1.08%) ⬇️
pkg/etcdutil/etcdutil.go 88.4% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba896bc...d8e9658. Read the comment docs.

server/schedule/placement/rule_manager.go Show resolved Hide resolved
server/schedule/placement/fit.go Show resolved Hide resolved
server/schedule/placement/fit.go Outdated Show resolved Hide resolved
server/schedule/placement/fit.go Outdated Show resolved Hide resolved
server/schedule/placement/rule_manager.go Outdated Show resolved Hide resolved
server/schedule/placement/rule_manager.go Outdated Show resolved Hide resolved
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
server/schedule/placement/fit.go Outdated Show resolved Hide resolved
server/schedule/placement/rule_manager.go Outdated Show resolved Hide resolved
server/schedule/placement/fit.go Show resolved Hide resolved
Signed-off-by: disksing <i@disksing.com>
Copy link
Contributor

@Luffbee Luffbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing
Copy link
Contributor Author

disksing commented Nov 4, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 4, 2019

/run-all-tests

@sre-bot sre-bot merged commit 8ea3f03 into tikv:master Nov 4, 2019
@disksing disksing deleted the placement5 branch November 4, 2019 15:45
@disksing disksing mentioned this pull request Dec 13, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants