statistics: abstract MovingAvg (rolling statistics) interface #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luffbee
added
component/schedule
lhy1024
approved these changes
Oct 25, 2019
| // MedianFilter works as a median filter with specified window size. | ||
| // There are at most `size` data points for calculating. | ||
| // References: https://en.wikipedia.org/wiki/Median_filter. | ||
| type MedianFilter struct { |
There was a problem hiding this comment.
would we add other MovingAvg?
nolouch
approved these changes
Oct 25, 2019
Luffbee
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
==========================================
+ Coverage 78.02% 78.04% +0.01%
==========================================
Files 168 168
Lines 17004 17009 +5
==========================================
+ Hits 13267 13274 +7
+ Misses 2649 2645 -4
- Partials 1088 1090 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There is a
RollingStatsstruct which is actually used to calculate moving average. The new hotspot scheduler will use similar structs to denoise or estimate the cluster status, so it useful to abstract an interface for it.What is changed and how it works?
Add an interface:
MovingAvg. It provides the basic methods:Add()andGet(), and two function may be useful in test:Reset()andSet().Rename the
RollingStatstoMedianFilterand modify it to satisfyMovingAvg.Check List
Tests