placement: add rule definitions #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
lhy1024
reviewed
Oct 28, 2019
rleungx
reviewed
Oct 28, 2019
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
- Coverage 78.1% 78.05% -0.06%
==========================================
Files 168 169 +1
Lines 17019 16975 -44
==========================================
- Hits 13293 13249 -44
- Misses 2644 2653 +9
+ Partials 1082 1073 -9
Continue to review full report at Codecov.
|
nolouch
approved these changes
Oct 28, 2019
Signed-off-by: disksing <i@disksing.com> Co-Authored-By: lhy1024 <admin@liudos.us>
rleungx
reviewed
Oct 29, 2019
| // applying rules (apply means schedule regions to match selected rules), the | ||
| // apply order is defined by the tuple [GroupID, Index, ID]. | ||
| type Rule struct { | ||
| GroupID string `json:"group_id"` // mark the source that add the rule |
There was a problem hiding this comment.
BTW, I think it's better to unify the style of it in the future. We have both snake_case and kebab-case in our repo.
There was a problem hiding this comment.
em, so are you suggesting using kebab style?
There was a problem hiding this comment.
Maybe we can decide later, now both styles are used commonly.
disksing
added
the
status/can-merge
|
/run-all-tests |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Add definitions for placement rules feature.
What is changed and how it works?
cannot work now.
Check List
Tests