tools: fix panic when using stores show limit (#1807) #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
sre-bot
added
area/pdctl
status/can-merge
lhy1024
approved these changes
Oct 16, 2019
|
/run-all-tests |
nolouch
approved these changes
Oct 16, 2019
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1807 to release-3.0
What problem does this PR solve?
If we firstly use
stores remove-tombstoneand then callingstores show limitinpd-ctl. It will panic due to the nil pointer.What is changed and how it works?
This PR fixes it by removing the store limit when removing a tombstone store.
Check List
Tests
Related changes