proposal: pluggable PD scheduler #1799

CheneyDing · 2019-10-12T10:19:51Z

What problem does this PR solve?

#1787

Synchronize with remote branch

nolouch

Thanks! generally it seems ok, we need more tests for load, unload, update

conf/move_leader_config.toml

server/api/plugin.go

server/handler.go

server/coordinator.go

tools/pd-ctl/pdctl/command/plugin_command.go

server/coordinator.go

server/schedule/plugin_interface.go

plugin/evict_leader/Makefile

server/handler.go

plugin/evict_leader/base_scheduler.go

plugin/evict_leader/evict_leader.go

server/api/plugin.go

plugin/grant_leader/grant_leader.go

server/schedule/plugin_interface.go

tools/pd-ctl/pdctl/command/plugin_command.go

server/coordinator.go

Co-Authored-By: lhy1024 <admin@liudos.us>

lhy1024

The Rest LGTM.

server/api/plugin.go

plugin/scheduler_example/evict_leader/base_scheduler.go

plugin/scheduler_example/grant_leader/grant_leader.go

server/coordinator.go

plugin/scheduler_example/evict_leader/base_scheduler.go

plugin/scheduler_example/evict_leader/evict_leader.go

plugin/scheduler_example/grant_leader/grant_leader.go

server/api/plugin.go

tools/pd-ctl/pdctl/command/plugin_command.go

server/api/plugin.go

tools/pd-ctl/pdctl/command/plugin_command.go

lhy1024 · 2019-10-23T07:29:42Z

would you like to address the problem that ci reported?

nolouch · 2019-12-04T11:13:24Z

I will help to add an integration test after this PR. PTAL @rleungx @lhy1024

server/schedule/plugin_interface.go

server/api/plugin.go

server/handler.go

server/coordinator.go

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

server/cluster/coordinator.go

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

server/schedule/plugin_interface.go

server/handler.go

rleungx

The rest LGTM.

server/cluster/coordinator.go

server/api/plugin.go

server/schedule/plugin_interface.go

tools/pd-ctl/pdctl/command/plugin_command.go

scheduler_example: fix conflict

Signed-off-by: nolouch <nolouch@gmail.com>

rleungx · 2019-12-17T02:46:06Z

PTAL @shafreeck

nolouch · 2019-12-18T03:14:04Z

/merge

sre-bot · 2019-12-18T03:16:18Z

/run-all-tests

CheneyDing added 4 commits October 9, 2019 16:32

Multi-plugin hot loading

812d090

Simplify plugin design

86a11a7

Merge remote-tracking branch 'upstream/master'

5876dbc

Synchronize with remote branch

remove unused files

73cb1fc

nolouch added the contributor label Oct 12, 2019

nolouch reviewed Oct 12, 2019

View reviewed changes

conf/move_leader_config.toml Outdated Show resolved Hide resolved

server/api/plugin.go Show resolved Hide resolved

server/handler.go Outdated Show resolved Hide resolved

server/coordinator.go Outdated Show resolved Hide resolved

server/coordinator.go Outdated Show resolved Hide resolved

nolouch added the component/schedule Scheduling logic. label Oct 12, 2019

nolouch requested review from rleungx, shafreeck and lhy1024 October 12, 2019 10:49

resolve some conversation

8148de7

rleungx reviewed Oct 14, 2019

View reviewed changes

lhy1024 reviewed Oct 14, 2019

View reviewed changes

CheneyDing and others added 6 commits October 14, 2019 22:00

Update plugin/evict_leader/base_scheduler.go

87a1f66

Co-Authored-By: lhy1024 <admin@liudos.us>

Update server/api/plugin.go

fdbf749

Co-Authored-By: lhy1024 <admin@liudos.us>

Update server/schedule/plugin_interface.go

229df0a

Co-Authored-By: lhy1024 <admin@liudos.us>

Update server/schedule/plugin_interface.go

ebae046

Co-Authored-By: lhy1024 <admin@liudos.us>

resolve some conversation

9838ece

resolve merge conflict

311658d

lhy1024 reviewed Oct 15, 2019

View reviewed changes

nolouch requested a review from disksing October 16, 2019 03:48

resolve some conversation

aee7903

lhy1024 reviewed Oct 21, 2019

View reviewed changes

resolve some conversation

bde6bae

rleungx reviewed Oct 22, 2019

View reviewed changes

server/api/plugin.go Outdated Show resolved Hide resolved

tools/pd-ctl/pdctl/command/plugin_command.go Outdated Show resolved Hide resolved

lhy1024 reviewed Oct 22, 2019

View reviewed changes

tools/pd-ctl/pdctl/command/plugin_command.go Outdated Show resolved Hide resolved

resolve some conversation

23f1a5c

CheneyDing added 2 commits October 23, 2019 16:15

resolve conflict

d119695

resolve conflict

a12ac54

rleungx reviewed Dec 4, 2019

View reviewed changes

CheneyDing and others added 6 commits December 4, 2019 20:09

Merge remote-tracking branch 'upstream/master' into plug-sche

a2e42dd

Update server/api/plugin.go

4eb027b

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

Update server/api/plugin.go

252889d

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

Update server/handler.go

c0d446f

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

resolve conflict

0d1a45c

modify coordinator

abdd00b

rleungx reviewed Dec 6, 2019

View reviewed changes

server/cluster/coordinator.go Outdated Show resolved Hide resolved

Update server/schedule/plugin_interface.go

3abccb6

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

rleungx reviewed Dec 6, 2019

View reviewed changes

server/schedule/plugin_interface.go Outdated Show resolved Hide resolved

remove unused code

56f88af

rleungx reviewed Dec 6, 2019

View reviewed changes

server/handler.go Show resolved Hide resolved

add lock for pluginChMap

3d15a2e

rleungx reviewed Dec 11, 2019

View reviewed changes

server/cluster/coordinator.go Show resolved Hide resolved

shafreeck reviewed Dec 11, 2019

View reviewed changes

server/api/plugin.go Outdated Show resolved Hide resolved

server/schedule/plugin_interface.go Outdated Show resolved Hide resolved

server/schedule/plugin_interface.go Outdated Show resolved Hide resolved

tools/pd-ctl/pdctl/command/plugin_command.go Outdated Show resolved Hide resolved

CheneyDing and others added 6 commits December 12, 2019 20:14

resolve some comment

1390342

Merge branch 'master' into plug-sche

3399dd3

Update evict_leader.go

5387f8e

scheduler_example: fix conflict

*: fix make plugin and add check

e6f00ba

Signed-off-by: nolouch <nolouch@gmail.com>

Merge branch 'master' into plug-sche

c6a47c9

Merge branch 'master' into plug-sche

d52cbaa

rleungx approved these changes Dec 18, 2019

View reviewed changes

sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2019

Merge branch 'master' into plug-sche

d37ecef

sre-bot merged commit 3583afd into tikv:master Dec 18, 2019

Huster-ljw pushed a commit to Huster-ljw/pd that referenced this pull request Dec 18, 2019

proposal: pluggable PD scheduler (tikv#1799)

6699b3f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

proposal: pluggable PD scheduler #1799

proposal: pluggable PD scheduler #1799

CheneyDing commented Oct 12, 2019

nolouch left a comment •

edited

Loading

lhy1024 left a comment

lhy1024 commented Oct 23, 2019

nolouch commented Dec 4, 2019 •

edited

Loading

rleungx left a comment

rleungx commented Dec 17, 2019

nolouch commented Dec 18, 2019

sre-bot commented Dec 18, 2019

proposal: pluggable PD scheduler #1799

proposal: pluggable PD scheduler #1799

Conversation

CheneyDing commented Oct 12, 2019

What problem does this PR solve?

nolouch left a comment • edited Loading

Choose a reason for hiding this comment

lhy1024 left a comment

Choose a reason for hiding this comment

lhy1024 commented Oct 23, 2019

nolouch commented Dec 4, 2019 • edited Loading

rleungx left a comment

Choose a reason for hiding this comment

rleungx commented Dec 17, 2019

nolouch commented Dec 18, 2019

sre-bot commented Dec 18, 2019

nolouch left a comment •

edited

Loading

nolouch commented Dec 4, 2019 •

edited

Loading