Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pd-ctl help output #1763

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Fix pd-ctl help output #1763

merged 4 commits into from
Sep 18, 2019

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 18, 2019

What problem does this PR solve?

Repair help output format.

Before:

# ./pd-ctl --help
Usage of ./pd-ctl:
      --cacert string   path of file that contains list of trusted SSL CAs.
      --cert string     path of file that contains X509 certificate in PEM format.
  -d, --detach          Run pdctl without readline (default true)
  -i, --interact        Run pdctl with readline
      --key string      path of file that contains X509 key in PEM format.
  -u, --pd string       The pd address (default "http://127.0.0.1:2379")
  -V, --version         print version information and exit
pflag: help requested

After:

# ./pd-ctl --help                                                                                                      
Usage of ./pd-ctl:
      --cacert string   The path of file that contains list of trusted SSL CAs.
      --cert string     The path of file that contains X509 certificate in PEM format.
  -d, --detach          Run pdctl without readline (default true).
  -h, --help            Help message.
  -i, --interact        Run pdctl with readline.
      --key string      The path of file that contains X509 key in PEM format.
  -u, --pd string       The pd address (default "http://127.0.0.1:2379").
  -V, --version         Print version information and exit.

Check List

Tests

  • Unit test

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #1763 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1763      +/-   ##
==========================================
- Coverage   76.92%   76.76%   -0.16%     
==========================================
  Files         162      162              
  Lines       15893    15893              
==========================================
- Hits        12225    12201      -24     
- Misses       2646     2662      +16     
- Partials     1022     1030       +8
Impacted Files Coverage Δ
pkg/etcdutil/etcdutil.go 72.46% <0%> (-15.95%) ⬇️
server/schedulers/shuffle_hot_region.go 58.97% <0%> (-6.42%) ⬇️
server/schedulers/random_merge.go 61.53% <0%> (-5.13%) ⬇️
server/tso/tso.go 81.65% <0%> (-3.67%) ⬇️
server/grpc_service.go 57.48% <0%> (-1.31%) ⬇️
server/server.go 82.21% <0%> (-0.58%) ⬇️
server/region_syncer/client.go 78.94% <0%> (+1.31%) ⬆️
server/member/leader.go 79.59% <0%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e5c35...39ffaeb. Read the comment docs.

@lhy1024 lhy1024 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 682b501 into tikv:master Sep 18, 2019
@lhy1024 lhy1024 deleted the pd-ctl-fix branch September 18, 2019 03:29
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
Signed-off-by: lhy1024 <admin@liudos.us>
(cherry picked from commit 682b501)
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
Signed-off-by: lhy1024 <admin@liudos.us>
(cherry picked from commit 682b501)
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
Signed-off-by: lhy1024 <admin@liudos.us>
(cherry picked from commit 682b501)
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 26, 2019
Signed-off-by: lhy1024 <admin@liudos.us>

(cherry picked from commit 682b501)
Signed-off-by: lhy1024 <admin@liudos.us>
sre-bot pushed a commit that referenced this pull request Sep 30, 2019
sre-bot pushed a commit that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants