schedule: fix scatter range #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
added
component/schedule
nolouch
added
the
needs-cherry-pick-release-3.0
|
Can we improve the metrics? now, it shares the same metrics with others. |
|
@nolouch The way I used is not elegant. I am not sure if there is a better to implement it. |
nolouch
reviewed
Jul 18, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
fix-scatter-range
branch
from
019bfbf
to
9ee518f
Compare
rleungx
removed
the
do-not-merge/work-in-progress
nolouch
approved these changes
Jul 24, 2019
|
/run-integration-ddl-test |
1 similar comment
|
/run-integration-ddl-test |
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Jul 24, 2019
* fix scatter range Signed-off-by: Ryan Leung <rleungx@gmail.com> * split scatter range metrics Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Jul 24, 2019
* fix scatter range Signed-off-by: Ryan Leung <rleungx@gmail.com> * split scatter range metrics Signed-off-by: Ryan Leung <rleungx@gmail.com>
disksing
pushed a commit
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There are some mistakes created by the previous PR which causes the scatter range scheduler cannot work.
What is changed and how it works?
This PR fixes it to make it work like before.
Check List
Tests
Related changes