Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule, schedulers: always merge left into right #1583

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

overvenus
Copy link
Member

Cherry picks #1564

Check List

Tests

  • Unit test

Code changes

  • Has configuration change

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1583 into release-3.0 will increase coverage by 0.1%.
The diff coverage is 61.11%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0    #1583     +/-   ##
==============================================
+ Coverage        67.41%   67.51%   +0.1%     
==============================================
  Files              159      159             
  Lines            16239    16253     +14     
==============================================
+ Hits             10947    10974     +27     
+ Misses            4317     4309      -8     
+ Partials           975      970      -5
Impacted Files Coverage Δ
server/config.go 82.18% <ø> (ø) ⬆️
server/cluster_info.go 85.16% <0%> (-0.35%) ⬇️
server/option.go 89.92% <0%> (-0.71%) ⬇️
server/schedule/mockcluster.go 83.09% <100%> (+0.12%) ⬆️
server/schedulers/random_merge.go 61.53% <50%> (-5.13%) ⬇️
server/schedule/merge_checker.go 78.68% <77.77%> (+4.61%) ⬆️
server/grpc_service.go 59.22% <0%> (-0.86%) ⬇️
server/handler.go 53.14% <0%> (-0.49%) ⬇️
client/client.go 68.19% <0%> (+0.41%) ⬆️
server/schedule/region_scatterer.go 86.95% <0%> (+0.72%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e6e08...bfca261. Read the comment docs.

@disksing disksing merged commit 772fb85 into tikv:release-3.0 Jun 17, 2019
@overvenus overvenus deleted the left-to-right branch June 17, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants