config: warn undefined config item #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
disksing
reviewed
Jun 11, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
|
Personally, I think this change will lose part of its original meaning of checking the config items. |
disksing
reviewed
Jun 12, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
disksing
reviewed
Jun 12, 2019
disksing
approved these changes
Jun 12, 2019
rleungx
approved these changes
Jun 13, 2019
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jun 17, 2019
* config: warn undefined config item Signed-off-by: nolouch <nolouch@gmail.com>
disksing
pushed a commit
that referenced
this pull request
Jun 17, 2019
* config: warn undefined config item (#1577) * config: warn undefined config item Signed-off-by: nolouch <nolouch@gmail.com> * *: add option to check label strictly (#1553) * *: add option to check tikv label strictly Signed-off-by: nolouch <nolouch@gmail.com> * config: disable label check by default (#1568) Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 2, 2019
* config: warn undefined config item Signed-off-by: nolouch <nolouch@gmail.com>
disksing
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Now, the undefined config item will let PD exit. This makes the new configuration item incompatible with the old configuration template.
What is changed and how it works?
Only log it with
warnlevel.Check List
Tests