Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: use a different timeout for http clients (#1574) #1576

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 11, 2019

What problem does this PR solve?

cherry-pick #1574.

What is changed and how it works?

This PR uses clients with a different timeout respectively for server, api and pd-ctl. And it changes the timeout of the client in server to 3 seconds.

Check List

Tests

  • Unit test
  • Integration test

* use a different timeout for http clients
@rleungx
Copy link
Member Author

rleungx commented Jun 11, 2019

/run-all-tests tidb=release-2.0 tikv=release-2.0 tidb-test=release-2.0

@shafreeck shafreeck self-requested a review June 20, 2019 08:17
Copy link
Contributor

@shafreeck shafreeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Contributor

CI failed

@mahjonp
Copy link

mahjonp commented Jun 27, 2019

/run-all-tests tidb=release-2.0 tikv=release-2.0 tidb-test=release-2.0

3 similar comments
@rleungx
Copy link
Member Author

rleungx commented Jun 27, 2019

/run-all-tests tidb=release-2.0 tikv=release-2.0 tidb-test=release-2.0

@rleungx
Copy link
Member Author

rleungx commented Jul 2, 2019

/run-all-tests tidb=release-2.0 tikv=release-2.0 tidb-test=release-2.0

@rleungx
Copy link
Member Author

rleungx commented Jul 2, 2019

/run-all-tests tidb=release-2.0 tikv=release-2.0 tidb-test=release-2.0

@disksing disksing merged commit 43a6ff8 into tikv:release-2.0 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants