Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add label distribution metrics #1402

Merged
merged 6 commits into from
Dec 29, 2018
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 28, 2018

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

add label distribution metrics.

What is changed and how it works?

more convenient to get the distribution information of the cluster

Check List

Tests

  • Unit test

Related changes

  • Need to update the tidb-ansible repository

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch requested review from disksing and rleungx December 28, 2018 12:02
@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #1402 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   75.45%   75.46%   +0.01%     
==========================================
  Files         135      135              
  Lines       13068    13078      +10     
==========================================
+ Hits         9860     9869       +9     
+ Misses       2315     2311       -4     
- Partials      893      898       +5
Impacted Files Coverage Δ
server/metrics.go 100% <100%> (ø) ⬆️
server/store_statistics.go 91.86% <84.61%> (+2.25%) ⬆️
server/api/redirector.go 78.94% <0%> (-5.27%) ⬇️
server/namespace_cluster.go 84.41% <0%> (-3.9%) ⬇️
server/etcd_kv.go 74.54% <0%> (-3.64%) ⬇️
server/core/kv.go 77.53% <0%> (-1.45%) ⬇️
server/leader.go 81.54% <0%> (-0.86%) ⬇️
server/grpc_service.go 53.17% <0%> (-0.49%) ⬇️
server/option.go 88.51% <0%> (ø) ⬆️
client/client.go 68.57% <0%> (+0.47%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa7bb3...0346bae. Read the comment docs.

Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/store_statistics.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
@huachaohuang
Copy link
Contributor

Why does the Jenkins unit test always fail?

@rleungx
Copy link
Member

rleungx commented Dec 29, 2018

@huachaohuang jenkins-ci-pd/unit-test is our old CI, which is not stable. And this week, I spent some time to make PD's tests run in parallel in idc-jenkins-ci/build. You can see the test result on here. But for now it will run these two CI at the same time. So the old CI could be failed sometimes. Maybe we can switch to idc-jenkins-ci/build which is more stable in the next week.

@huachaohuang
Copy link
Contributor

OK, thanks.

Copy link
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huachaohuang huachaohuang merged commit 7fac1b2 into tikv:master Dec 29, 2018
@nolouch nolouch deleted the place-metrics branch December 29, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants