Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Fix the issue about RaftCluster cannot be stopped #1370

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 12, 2018

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

the RaftCluster probability can't stop cause by deadlock.

What is changed and how it works?

fix the mutex usage.

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added type/bug The issue is confirmed as a bug. needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. labels Dec 12, 2018
server/cluster.go Outdated Show resolved Hide resolved
server/cluster_test.go Outdated Show resolved Hide resolved
@disksing disksing merged commit e8b8a8e into tikv:master Dec 12, 2018
nolouch added a commit to nolouch/pd that referenced this pull request Dec 12, 2018
* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>
disksing pushed a commit that referenced this pull request Dec 12, 2018
)

* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch deleted the fix-cluster-stop branch December 12, 2018 11:36
@rleungx rleungx added the needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. label Dec 13, 2018
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 13, 2018
* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch added a commit to nolouch/pd that referenced this pull request Dec 14, 2018
* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>
siddontang pushed a commit that referenced this pull request Dec 14, 2018
)

* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants