Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdctl: fix decode key #1308

Merged
merged 2 commits into from
Nov 6, 2018
Merged

pdctl: fix decode key #1308

merged 2 commits into from
Nov 6, 2018

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Nov 5, 2018

What problem does this PR solve?

The command region key does not support all escaped keys generated by golang "%q".

What is changed and how it works?

Support all runes listed in https://golang.org/ref/spec#Rune_literals

Check List

Tests

  • Manual test (add detailed scripts or steps below)

@nolouch nolouch merged commit ebc6d84 into tikv:master Nov 6, 2018
@disksing disksing deleted the decode-literal branch November 6, 2018 03:39
@disksing disksing added the needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. label Nov 7, 2018
disksing added a commit to oh-my-tidb/pd that referenced this pull request Nov 8, 2018
disksing added a commit that referenced this pull request Nov 8, 2018
* pdctl: fix region key problems in detach mode (#1298)

* pd-ctl: escape the key before query the corresponding region (#1299)

* pdctl: fix decode key (#1308)

Signed-off-by: disksing <i@disksing.com>
@nolouch nolouch added the needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. label Nov 13, 2018
disksing added a commit to oh-my-tidb/pd that referenced this pull request Nov 14, 2018
disksing added a commit that referenced this pull request Nov 14, 2018
* server, client: fix hanging problem when etcd failed to start (#1267)

* server: use same initialcluster config to restart joined member (#1279)

* fix server build

* pdctl: cherry pick bugfixes (#1298, #1299, #1308)

* server/api: fix the issue about `regions/check` API (#1311)

* fix join build

* fix pdctl build

* fix region test

* fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants