Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-api: get regions with top size #1254

Merged
merged 5 commits into from
Sep 26, 2018
Merged

Conversation

liukun4515
Copy link
Contributor

What problem does this PR solve?

  • add HTTP API and pd-ctl to get the regions with the top size.

What is changed and how it works?

  • add HTTP API for getting regions with the top size.
  • add pd-ctl command.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has HTTP API interfaces change

Side effects

no

Related changes

  • Need to update the documentation

@disksing
Copy link
Contributor

Don't forget to update the api.raml file too.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@liukun4515
Copy link
Contributor Author

PTAL @disksing

@disksing disksing merged commit 75e4b91 into tikv:master Sep 26, 2018
@liukun4515 liukun4515 deleted the top-size-region branch September 26, 2018 05:27
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants