pd-ctl: support topconfver and topversion #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
force-pushed
the
top-confver-version
branch
from
4ee554d
to
d10d053
Compare
disksing
reviewed
Sep 4, 2018
pdctl/command/region_command.go
Outdated
|
|
||
| topConfVer := &cobra.Command{ | ||
| Use: "topconfver <limit>", | ||
| Short: "show regions with top conf verion", |
server/api/region_test.go
Outdated
| mustRegionHeartbeat(c, s.svr, r3) | ||
| s.checkTopFlow(c, fmt.Sprintf("%s/regions/writeflow", s.urlPrefix), []uint64{2, 1, 3}) | ||
| s.checkTopFlow(c, fmt.Sprintf("%s/regions/readflow", s.urlPrefix), []uint64{1, 3, 2}) | ||
| s.checkTopFlow(c, fmt.Sprintf("%s/regions/writeflow?limit=2", s.urlPrefix), []uint64{2, 1}) | ||
| s.checkTopFlow(c, fmt.Sprintf("%s/regions/confver", s.urlPrefix), []uint64{3, 2, 1}) |
There was a problem hiding this comment.
I suppose you have to change checkTopFlow to another name.
disksing
approved these changes
Sep 5, 2018
|
PTAL. @nolouch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related to #1092.
What is changed and how it works?
This PR provides a way to list top regions whose conf version or version is the largest. After this PR, we can use
region topconfver <limit>orregion topversion <limit>inpd-ctlto find what we want.Check List
Tests