pd-ctl: list all regions in a specified store #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
changed the title
rleungx
changed the title
disksing
reviewed
Sep 3, 2018
server/core/region.go
Outdated
| // GetStoreRegions gets all RegionInfo with a given storeID | ||
| func (r *RegionsInfo) GetStoreRegions(storeID uint64) []*RegionInfo { | ||
| var regions []*RegionInfo | ||
| for _, region := range r.regions.m { |
There was a problem hiding this comment.
I think better to iterate leaders and followers.
|
The rest LGTM. |
|
Oh, don't forget to update api.raml file. |
rleungx
force-pushed
the
regions-in-store
branch
from
59aa9f7
to
6529db7
Compare
disksing
reviewed
Sep 4, 2018
server/core/region.go
Outdated
| @@ -630,6 +630,22 @@ func (r *RegionsInfo) GetRegions() []*RegionInfo { | |||
| return regions | |||
| } | |||
|
|
|||
| // GetStoreRegions gets all RegionInfo with a given storeID | |||
| func (r *RegionsInfo) GetStoreRegions(storeID uint64) []*RegionInfo { | |||
| var regions []*RegionInfo | |||
There was a problem hiding this comment.
Can we pre-allocates the slice with capacity?
server/core/region.go
Outdated
| var regions []*RegionInfo | ||
| if leaders, ok := r.leaders[storeID]; ok { | ||
| for _, region := range leaders.m { | ||
| regions = append(regions, region.Clone()) |
There was a problem hiding this comment.
Seems no need to Clone any more after the refactor of RegionInfo. /cc @nolouch
disksing
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #511.
What is changed and how it works?
This PR adds API to list all regions in a specified store. After this PR is merged, we can use
region store <id>to print all regions in a specified store by usingpd-ctl.Check List
Tests