Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TiDB behavior: alter table order by #608

Closed
tangenta opened this issue Oct 31, 2019 · 0 comments · Fixed by pingcap/tidb#14324
Closed

Fix TiDB behavior: alter table order by #608

tangenta opened this issue Oct 31, 2019 · 0 comments · Fixed by pingcap/tidb#14324
Labels
good first issue Good for newcomers

Comments

@tangenta
Copy link
Contributor

Index issue: #598

SQL example

ALTER TABLE t ORDER BY a, b;

Current implementation

AlterTableOrderByColumns is ignored by TiDB.

Expected implementation

Throw a warning if a table has the primary key. Refer to MySQL error

Warning | 1105 | ORDER BY ignored as there is a user-defined clustered index in the table '%s'
@tangenta tangenta mentioned this issue Oct 31, 2019
Closed
11 tasks
@kennytm kennytm changed the title Fix TiDB behavior: order by Fix TiDB behavior: alter table order by Oct 31, 2019
@tangenta tangenta added the good first issue Good for newcomers label Dec 11, 2019
@yuanjize yuanjize mentioned this issue Jan 2, 2020
Merged
@tangenta tangenta closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: throw warning when ALTER TABLE ORDER BY on table with primary key yuanjize/tidb
1 participant
@tangenta