Fix TiDB behavior: with validation

[tangenta]

Index issue: #598

SQL example

ALTER TABLE t WITH VALIDATION;

Current implementation

AlterTableWithValidation is ignored by TiDB.

Expected implementation

Throw a warning only when the table is with validation.

[yuanjize]

Should these problem about incompatible statements be fixed in repo parser or repo tidb?

[tangenta]

@yuanjize We need to update the code in TiDB repo.

[tangenta]

@yuanjize If you have any questions, feel free to ask here or contact me on slack :).

Slack: channel #sig-parser in the tidbcommunity slack workspace.

[cncal]

@tangenta , I'm working on this issue as a new contributor. A warning is threw when I execute ALTER TABLE t WITH VALIDATION; and the warning is as follows:

1064 You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 30 near ""The WITH/WITHOUT VALIDATION clause is parsed but ignored by all storage engines.

Has this issue been solved already?

[tangenta]

@cncal This issue has not been fixed yet. Your contribution is welcomed :)

[cncal]

I think the warning has been generated by parser, should I remove the code that generates the warning in parser and throw the warning in tidb?

[tangenta]

Yes, you can remove the warning in parser.