-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TiDB behavior: constraint check #601
Comments
@tangenta , I'm trying to solve this issue as a new contributor. where should I throw a warning, in pingcap/parser or pingcap/tidb? (I think it should be fixed in pingcap/tidb, but the issue is under pingcap/parser, a bit confused) |
@chanme It should be fixed in pingcap/tidb :) |
I have almost finished solving this issue, during writing the unit tests, I find out that some warnings are already generated by the pingcap/parser repo, should I first make a PR to remove the warning in the parser then add warning in pingcap/tidb to solve this issue? Original Warning is: |
Index issue: #598
SQL example
Current implementation
ColumnOptionCheck
,ConstraintType.ConstraintCheck
,AlterTableAlterCheck
, andAlterTableDropCheck
are ignored by TiDB.Expected implementation
Throw a warning.
The text was updated successfully, but these errors were encountered: