Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

br support http download #308

Open
zhouqiang-cl opened this issue May 26, 2020 · 1 comment
Open

br support http download #308

zhouqiang-cl opened this issue May 26, 2020 · 1 comment
Labels
difficulty/2-medium Medium-difficulty issue priority/P2 Medium priority issue type/feature-request New feature or request

Comments

@zhouqiang-cl
Copy link
Contributor

Feature Request

Describe your feature request related problem:

Now we just support local or s3 to backup. but local eat too much disk and s3 is expensive. I think we can support download from HTTP

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@zhouqiang-cl zhouqiang-cl added the type/feature-request New feature or request label May 26, 2020
@kennytm kennytm added difficulty/2-medium Medium-difficulty issue priority/P2 Medium priority issue labels May 28, 2020
@kennytm
Copy link
Collaborator

kennytm commented May 28, 2020

Note that in the current design, an external storage cannot "just support download". It must define all these 3 operations:

  1. Download a file
  2. Upload a file
  3. Checks if a file exists

An HTTP storage clearly supports operation 1 and 3 via GET and HEAD requests. The question is what should operation 2 do.

(In CrDB's BACKUP statement, it will issue a PUT request with the body being the file.)

Additionally, if we want to support Lightning, we will need this additional operation which definitely isn't supported by HTTP:

  1. Recursively list content of directory

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty/2-medium Medium-difficulty issue priority/P2 Medium priority issue type/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants