This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Export OAuth2 token response interfaces #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomuser
changed the title
src/oauth2/index.ts
Outdated
| @@ -162,12 +162,12 @@ export class OAuth2RequestError extends Error { | |||
| } | |||
| } | |||
|
|
|||
| interface TokenErrorResponseBody { | |||
| export interface TokenErrorResponseBody { | |||
There was a problem hiding this comment.
I believe this is an internal type in that there are no public APIs or generics that use it
There was a problem hiding this comment.
Good point. I've removed the export. At first I had considered the interface could also be useful externally, but you're right it makes less sense if it is not actually part of the public API.
pilcrowonpaper
approved these changes
Feb 17, 2024
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples in the documentation show that one can extend the
TokenResponseBodyinterface, e.g. to add an id_token for OpenId Connect. However, that interface is not exported from the library. This PR is a tiny fix to export both interfaces which cover the token response types.