Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option "-3" not supported in bgpq4, results in Errors at the script #95

Closed
stkonst opened this issue Jan 20, 2022 · 3 comments
Closed
Milestone

Comments

@stkonst
Copy link

stkonst commented Jan 20, 2022

Hi there,

Line 203 of irrdb.py puts the option "-3" by default on the bgpq3/bgpq4 commands. However, this option is not supported in bgpq4 and thus, generates errors like the following:

ARouteServer 2022-01-20 15:10:40,175 ERROR Error while retrieving IPv6 prefixes from AS203101 for client AS203101_1: Can't get authorized prefix list for AS203101 IPv6: Error while parsing bgpq4 output for the following command: 'bgpq4 -h rr1.ntt.net -S RIPE,APNIC,AFRINIC,ARIN,NTTCOM,ALTDB,BBOI,BELL,JPIRR,LEVEL3,RADB,RGNET,TC -3 -j -6 -A -l prefix_list AS203101': bgpq4 exit code is 1, stderr: b"bgpq4: invalid option -- '3'\n" - No more attempts will be performed, all the hosts in the list failed.

By disabling/commenting this line the process goes on successfully.

@pierky
Copy link
Owner

pierky commented Jan 20, 2022

Hello @stkonst, thanks for reporting this issue.

It seems that the -3 option has been dropped from bgpq4 recently. In the past it was added as a no-op just to keep compatibility with the bgpq3 syntax.

I've just pushed a pre-release for 1.13.1, where this should be fixed: v1.13.1-alpha1. The CI/CD pipeline is now running, and if everything goes well it should be pushed to the test instance of PyPi in about one hour. It'd be great if you could give it a try. In case, you can find instructions on how to install it from the test instance on this page: https://arouteserver.readthedocs.io/en/latest/INSTALLATION.html#development-and-pre-release-versions

Thanks a lot

@stkonst
Copy link
Author

stkonst commented Jan 20, 2022

You are welcome, thank's for the quick fix. I will give it a try as well.

@pierky pierky added this to the v1.13.1 milestone Jan 22, 2022
@pierky pierky closed this as completed in c055b4c Jan 23, 2022
@pierky
Copy link
Owner

pierky commented Jan 23, 2022

v1.13.1 is out with this fix/improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants