Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeeringDB API calls for clients-from-peeringdb done without API key #139

Closed
pierky opened this issue Jul 15, 2024 · 2 comments
Closed

PeeringDB API calls for clients-from-peeringdb done without API key #139

pierky opened this issue Jul 15, 2024 · 2 comments

Comments

@pierky
Copy link
Owner

pierky commented Jul 15, 2024

PeeringDB API calls made to handle the clients-from-peeringdb command are done without the API key:

GET /api/net?asn=xxx
GET /api/netixlan?ixlan_id=xxx
@pierky
Copy link
Owner Author

pierky commented Jul 15, 2024

The clients-from-peeringdb command performs multiple PDB API calls
sequentially to obtain ASNs' info. Users reported some errors related to
429s and an investigation on the PeeringDB side showed some logs where
those API calls were made without any API key.

Even though I was not able to reproduce the issue (all the API
calls were made with the proper API key) I introduce here this
workaround to reduce the n. of calls made in one minute, to match the
limit on the PeeringDB side.

@pierky
Copy link
Owner Author

pierky commented Jul 15, 2024

I've just pushed out a new alpha release that contains this fix. If CI/CD will be happy, it will be available under the PyPi test instance in a few hours. It will be possible to install it by following the instructions at https://arouteserver.readthedocs.io/en/latest/INSTALLATION.html#development-and-pre-release-versions

If everything goes well, I plan to ship it as part of a new release in a few days.

@pierky pierky closed this as completed in eb4f4d3 Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant