Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database location #21

Closed
Dom-Pieces opened this issue Feb 2, 2024 · 0 comments
Closed

Database location #21

Dom-Pieces opened this issue Feb 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Dom-Pieces
Copy link
Contributor

The way we're currently using the sqlite db requires us to package it up with the python package. This is generally not a good practice .

It might be cleaner to put the db in a location such as next to our other com.pieces.os contents, but afaik poetry (that is our current build manager) does not currently support setuptools' data_files.

Alternatively we might want to allow cli's user to specify it themselves wherever they see fit, e.g. with some config file, or by supplying the path as an option in the cli.

Not sure what the optimal course of action for this is here, but we should be aware of this, hence I'm raising this issue.

@Dom-Pieces Dom-Pieces added the enhancement New feature or request label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants