Throw error when lending pool is zero address

pie-dao · Dec 7, 2020 · bd652b2 · bd652b2
1 parent 91e5837
commit bd652b2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/contracts/callManagers/LendingManager/LendingLogicAave.sol b/contracts/callManagers/LendingManager/LendingLogicAave.sol
@@ -13,6 +13,7 @@ contract LendingLogicAave is ILendingLogic {
     uint16 public referralCode;
 
     constructor(address _lendingPool, uint16 _referralCode) {
+        require(_lendingPool != address(0), "LENDING_POOL_INVALID");
         lendingPool = IAaveLendingPool(_lendingPool);
         referralCode = _referralCode;
     }

diff --git a/test/lendingLogicAave.ts b/test/lendingLogicAave.ts
@@ -53,6 +53,11 @@ describe("LendingLogicAave", function() {
         await timeTraveler.revertSnapshot();
     });
 
+    it("Deploying with lendingPool set to the zero address should fail", async() => {
+        const promise = deployContract(signers[0], LendingLogicAaveArtifact, [constants.AddressZero, 0]);
+        await expect(promise).to.be.revertedWith("LENDING_POOL_INVALID");
+    });
+
     it("lend()", async() => {
         const calls = await lendingLogic.lend(token.address, mintAmount);