Improve trigger threshold computation #211
Labels
Enhancement
New feature or request
Good first issue
Good for newcomers
Hacktoberfest
Issue/PR for hacktoberfest. Completing this issue/PR might not grant the all-contributor recognition
Detailed Description
While working on #206 @sangfrois and I realised that the current approach to compute the threshold fails for multi-runs recordings. Digging into the matter a bit deeper, I realised that this happens if, in absence of noise:
As an easy fix, we could set the threshold to be one standard deviation from the average, instead of two standard deviations from the average.
Testing it a bit more with noisy signal, I realised that one standard deviation from average wouldn't be enough to proper threshold points if:
A less easy fix in this case would be reconsidering the options in #173 and implement a different approach.
Possible Implementation
In case we decide to go for option 1, please relabel this issue as bug and the PR as BugFIX
The text was updated successfully, but these errors were encountered: