Skip to content

Latest commit

 

History

History
45 lines (30 loc) · 2.06 KB

README-CodingConventions.md

File metadata and controls

45 lines (30 loc) · 2.06 KB
Raw

Coding Convensions

NOTE

These conventions are not yet adhered to by the Sunflower implementation, portions of which date from 1999. Please however do adhere to it for all new code.

Example

To see a recent pull request that applies some of these rules to cleaning up code, see the pull request for issue #132.

Conventions

  1. Code indented with tabs, not spaces. If you use vim, set your .vimrc as follows so you can see where you have stray spaces:
set list
set listchars=tab:>-

For visual alignment, assume the code will be viewed in an editor where tabs are rendered to be as wide as eight spaces.

  1. Variable names in camelCase.

  2. Type names begin with a capital. Type names specific to Sunflower begin with Sunflower, e.g., SunflowerSymbolType.

  3. Constant names and enum entries begin with kSunflower, e.g., kSunflowerIrNodeType_PintegerType.

  4. C-style comments, in the form:

	/*
	 *	Comment (offset with a single tab)
	 */

  1. Comments are not just "notes to self". They should provide useful explanatory information.

  2. No #include within header .h files if possible.

  3. No function definitions in header .h files.

  4. Files named named module <sunflower>-camelCasedModuleName, e.g., sunflower-xxxcamelCasedName.c.

  5. Constants in enums, not in #defines where possible.

  6. Avoid #define if possible.

  7. All if statement followed by curly braces, even if body is a single statement.

  8. The pattern \t\n (tab followed by newline) should never occur in a source file.

  9. Except for temporary debugging statements, all print statements should use flexprint from the libflex library (https://github.com/phillipstanleymarbell/libflex). This allows us to buffer print statements and makes the web interface/demos and other deployments possible. Errors go into the buffer Fperr and informational output (almost everything that is not an error) goes into Fpinfo. We sometimes have additional dedicated buffers to isolate certain outputs.