OffsetAccessValueAssignmentRule optimization for huge arrays

ondrejmirtes · ondrejmirtes · commit a07996a9cad1 · 2024-10-26T13:02:51.000+02:00
diff --git a/src/Rules/Arrays/OffsetAccessValueAssignmentRule.php b/src/Rules/Arrays/OffsetAccessValueAssignmentRule.php
@@ -46,6 +46,10 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$arrayDimFetch = $node->var;
+		$varType = $scope->getType($arrayDimFetch->var);
+		if ($varType->isObject()->no()) {
+			return [];
+		}
 
 		if ($node instanceof Assign || $node instanceof Expr\AssignRef) {
 			$assignedValueType = $scope->getType($node->expr);

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,10 @@ public function processNode(Node $node, Scope $scope): array`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`$arrayDimFetch = $node->var;`
	`49`	`+ $varType = $scope->getType($arrayDimFetch->var);`
	`50`	`+ if ($varType->isObject()->no()) {`
	`51`	`+ return [];`
	`52`	`+ }`
`49`	`53`
`50`	`54`	`if ($node instanceof Assign \|\| $node instanceof Expr\AssignRef) {`
`51`	`55`	`$assignedValueType = $scope->getType($node->expr);`