Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertMethodTypeSpecifyingExtension does not target the correct class #103

Closed
nreynis opened this issue Sep 30, 2021 · 1 comment · Fixed by #106
Closed

AssertMethodTypeSpecifyingExtension does not target the correct class #103

nreynis opened this issue Sep 30, 2021 · 1 comment · Fixed by #106

Comments

@nreynis
Copy link

nreynis commented Sep 30, 2021

AssertMethodTypeSpecifyingExtension is narrowing types on TestCase but it should really operate on PHPUnit\Framework\Assert where the actual methods are implemented.

The current codebase means that you can have a working assertSomething method in your test case that breaks when you factorize it in a dedicated class (class SomethingAsserter extends Assert)

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant