Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubjectInfoAccessSyntax var is not defined #1808

Closed
come-nc opened this issue Jun 21, 2022 · 7 comments
Closed

SubjectInfoAccessSyntax var is not defined #1808

come-nc opened this issue Jun 21, 2022 · 7 comments

Comments

@come-nc
Copy link
Contributor

come-nc commented Jun 21, 2022

Hello,

In 2.0, SubjectInfoAccessSyntax property of phpseclib\File\X509 is not declared.

(Spotted by running a dev build of PHP 8.2 which now warns about such things)

@terrafrost
Copy link
Member

Looks like it's defined to me?:

$this->SubjectInfoAccessSyntax = array(
'type' => ASN1::TYPE_SEQUENCE,
'min' => 1,
'max' => -1,
'children' => $AccessDescription
);

(it's defined in the constructor along with pretty much every other property)

Can you post the full error message you're getting? Maybe some sample code that demonstrates the problem on PHP 8.2?

@jack-worman
Copy link
Contributor

I believe the problem is that $this->SubjectInfoAccessSyntax is defined dynamically. It does not have a property declaration: public $SubjectInfoAccessSyntax;

@terrafrost
Copy link
Member

Good catch!

f61a9b4 should fix this.

Thanks!

@come-nc
Copy link
Contributor Author

come-nc commented Jun 23, 2022

Thank you ❤️

@come-nc
Copy link
Contributor Author

come-nc commented Aug 30, 2022

@terrafrost Hello, would it be possible to have a 2.0 release with this fix?

@terrafrost
Copy link
Member

I'm gonna do a release within the next few days!

@terrafrost
Copy link
Member

2.0.38 has been released.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants