Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CodeGenerator / Strategy / Navigator / Visitor #28

Closed
gossi opened this issue May 29, 2016 · 1 comment
Closed

Simplify CodeGenerator / Strategy / Navigator / Visitor #28

gossi opened this issue May 29, 2016 · 1 comment
Milestone

Comments

@gossi
Copy link
Collaborator

gossi commented May 29, 2016

This is still code from the old cg-library. Yet I added CodeGenerator in front of it and gave it a nice API to work with. While the Visitor Pattern still seems very good in that situation, it still looks too complex in total. Should be simplified by any means.

Ref #23

@gossi
Copy link
Collaborator Author

gossi commented Nov 5, 2016

Things to think about:

  • Divide GeneratorVisitor into smaller chunks so it can be used for testing to generate PhpParameter or PhpProperty, etc. code
  • extract sorting to config, having something like this: CodeGenerator(['sortMethods' => false]) to even deactivate sorting. Maybe provide some presets for sorting.

@gossi gossi modified the milestone: Version 0.4 Nov 8, 2016
@gossi gossi closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant