Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CONST_CS flag #17071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unused CONST_CS flag #17071

wants to merge 1 commit into from

Conversation

DanielEScherzer
Copy link
Contributor

No description provided.

@DanielEScherzer
Copy link
Contributor Author

Pretty confident that the failure is unrelated:

========DIFF========
001+ [0454] Expecting string/2024-12-06 21:07:39, got string/2024-12-06 21:07:38 resp. string/2024-12-06 21:07:38. [0] 
     OK
========DONE========
FAIL mysqli_fetch_all() data types variation [ext/mysqli/tests/fetch/mysqli_fetch_all_data_types_variation.phpt]

@cmb69
Copy link
Member

cmb69 commented Dec 18, 2024

Generally fine, but might be better to wait for the next major version of PHP.

@kocsismate
Copy link
Member

Yes, this change is an ABI break which 3rd party extension have to account for. Since gen_stub.php was recently got rid of using this flag, there are possibly still quite some usages. In order to avoid unnecessarily nagging maintainers, I'd also vote for delaying the removal until PHP 9.0.

@cmb69 cmb69 added this to the PHP 9 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ABI break Category: Engine
Projects
None yet
Milestone
PHP 9
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielEScherzer @cmb69 @kocsismate