Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fopen/fread with file_get_contents #276

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

ideag
Copy link
Contributor

@ideag ideag commented Nov 5, 2021

Fixes #257

@ideag
Copy link
Contributor Author

ideag commented Nov 5, 2021

@oscarotero If I understand correctly PHP codesniffer v3.4.2 is having trouble running on php 8.0?

@oscarotero
Copy link
Member

Hi, thanks for this (and your sponsor!!). It looks good to me.

Yep, PHP codesniffer added support for PHP8 starting from 3.5. This error is from Scrutinizer that I'm going to remove it because it seems that it wasn't updated for long time.

@oscarotero oscarotero merged commit e519626 into php-gettext:master Nov 5, 2021
@ideag
Copy link
Contributor Author

ideag commented Nov 5, 2021

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsequent loadFile fails
2 participants