Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline disabled translations #263

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Conversation

lbfeenix
Copy link
Contributor

If .po file contain multiline disbled translations like this:

#~ msgid "Last agent hours-description"
#~ msgstr ""
#~ "How many hours in the past can system look at finding the last agent? "
#~ "This parameter is only used if 'Call Last Agent' is set to 'YES'."

only the first line was taken, this fix allow mutiline disabled translations.

src/Loader/PoLoader.php Outdated Show resolved Hide resolved
oscarotero added a commit that referenced this pull request Nov 17, 2020
@oscarotero
Copy link
Member

Thanks @lbfeenix
I've added this test case: 219a7e6, so please make sure it is passed.
I've also leave one comment in your code.

@oscarotero oscarotero merged commit fb47657 into php-gettext:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants