-
Notifications
You must be signed in to change notification settings - Fork 33
dev_quick_start_continue
Vyacheslav Semushin edited this page Mar 12, 2018
·
18 revisions
-
create a separate branch where you will be working on the issue. This branch should be based on the
master
branch:$ git checkout -b ghXXX_meaningful_name master
where
XXX
is the issue number andmeaningful_name
is a very short description of the issue. -
modify files that needed to add a feature/fix the issue, create commit(s)
-
after fixing an issue, run integration tests to be sure that you didn't break anything else
-
push branch to the GitHub
-
create Pull Request in php-coder/mystamps repository:
- open https://github.com/php-coder/mystamps/pulls
- click on button "Create pull request"
- fill the relevant fields
- append
Addressed to #XXX
to the description
-
check the report from TravisCI and fix possible errors from different tools for static analysis
-
wait for a code review
-
(optional) create more commits to fix comments after code review
-
(optional) squash all the commits to one (and do
git push --force-with-lease
)