Hide overlay icons when photo detail is clicked

[damianmoore]

When viewing a photo in detail it can de distracting to see icons on top of it. In most phone gallery apps you can tap once to make the icons disappear.

• Tap once to hide icons
• When icons hide, any bounding boxes should also hide
• Tap again once shows the icons (and bounding boxes if shown previously) again
• When the icons have disappeared you should still be able to pinch zoom in on the photo
• Double tap action shouldn't show/hide icons as this is reserved for zoom in
• User can exit the photo detail with their browser/hardware back button but the icons should show by default for the next photo detail viewed

[GyanP]

I have completed the task and changes pushed on branch 279-hide-overlay-icons.

[damianmoore]

Hi @GyanP, I've ticked off the checkboxes above for the ones that I'm happy with.

The icons are not hiding exactly as I was intending. These are what should be hidden as well as the bounding boxes:

Having played with it a bit more I've realised that some other things need to be done with regard to the metadata info sidebar on the right (if it showing).

• When the sidebar is shown, make sure the icons (and bonding boxes if turned on) are showing
• If the area highlighted is clicked, hide the metadata info sidebar - do not hide the icons of bounding boxes as would happen if the sidebar was not showing.
• Once sidebar is hidden again, single click and double-click actions are restored.

[GyanP]

modification done and changes pushed on branch 279-hide-overlay-icons

[GyanP]

modification done and changes pushed on branch 279-hide-overlay-icons

[damianmoore]

Thanks @GyanP. Merged as of cecf477.