Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow definition of redis & postgresql port #267

Closed
Idly41 opened this issue May 26, 2021 · 3 comments
Closed

Enhancement: Allow definition of redis & postgresql port #267

Idly41 opened this issue May 26, 2021 · 3 comments
Assignees
Labels
Milestone

Comments

@Idly41
Copy link

Idly41 commented May 26, 2021

Is your feature request related to a problem? Please describe.
Not really related to a problem, more a matter of principles :-).

As it seems, photonix uses the default ports for redis (6379) and postgres (5432).
In my infrastructure, I try to avoid static ports and use dynamic port assignments as much as possible.

Describe the solution you'd like
I would appreciate the ability to configure these ports via environment variables.

Describe alternatives you've considered
None really.

Additional context
Modern container based infrastructure are very dynamic and avoid static ports and IPs in order to allow the necessary flexibility (Kubernetes, Nomad, etc.)

@damianmoore
Copy link
Collaborator

Thanks @abmurksi - sounds important.

@Idly41
Copy link
Author

Idly41 commented May 26, 2021

Not really important at the moment, but will be helpful in different deployment contexts.
And btw, many thanks for Photonix! It looks very well designed and shows a lot of promise!! I look forward to ride the journey with you :-)

@damianmoore damianmoore self-assigned this Jun 26, 2021
@damianmoore damianmoore added this to the 1.0 milestone Jun 26, 2021
@damianmoore
Copy link
Collaborator

Merged as of 10f2775 and v0.12.0. Full list of environment variables here: https://photonix.org/docs/configuration/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants