Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete when search string matches available tags #226

Closed
damianmoore opened this issue Apr 14, 2021 · 4 comments
Closed

Autocomplete when search string matches available tags #226

damianmoore opened this issue Apr 14, 2021 · 4 comments
Assignees
Labels
Milestone

Comments

@damianmoore
Copy link
Collaborator

When user starts typing, if their text matches any of the available tags/filters, then those tags should be listed as a dropdown with their category name and icon. User should be able to add a matched tag to their search string by clicking or using arrow keys up/down and then enter or tab key.

autocomplete_mockup

@damianmoore damianmoore added this to the 1.0 milestone Apr 14, 2021
@GyanP
Copy link
Collaborator

GyanP commented May 7, 2021

I have completed the task and pushed on branch "226-autocompleta-search".

@damianmoore
Copy link
Collaborator Author

Hi @GyanP. This looks really nice and I like the interactivity with keyboard arrow keys - very quick to use.

However I noticed a couple of problems I hope will be simple enough to fix. Selecting a tag from the autocomplete list behaves differently to if it was clicked from the main filters panel.

  1. There is no box around it with the x button and icon
  2. The faceted search does not update

See video for comparison of the two modes:

Screencast.from.16-06-21.23.42.35.mp4

@GyanP
Copy link
Collaborator

GyanP commented Jun 17, 2021

Updation done for the task and changes pushed on branch 226-autocompleta-search.

@damianmoore
Copy link
Collaborator Author

Merged as of c702605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants