-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for server components #32
Comments
+1 |
1 similar comment
+1 |
+1 |
+1 |
Hey all. Looking into this for upcoming 2.0 release 👍 |
My favorite icons, I like them so much. I am incredibly grateful to the creators 😍 |
Wondering what people feel would be good default styling in lieu of context server-side -- black, regular weight, 1em size? |
+1 |
I feel like that these are pretty good default values and is what I would expect. |
Having read and partially 😂 understood the RFC, it seems that a It would be really nice, although maybe quite complex, if we had some sort of conditional directive to allow different behaviors on server- and client-side, a la: let defaultValues = { size, weight, color, mirrored };
"if client";
defaultValues = useContext(IconContext);
"endif"; |
Any updates on this topic? |
Prelim support added in |
I love this library! |
Is there an update? |
still waiting |
With the release of React 18 (and NextJS 13), server components are supported and will most certainly get utilized more going forward. It would be nice of phosphor-react to support this. It does currently seem to be limited by the usage of
React.Context
.Possible solutions would be to use the
"use client"
directive (reactjs/rfcs#227) or in some way make the context optional.The text was updated successfully, but these errors were encountered: