-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uninstall stanza for Jawbone Updater #3431
Conversation
Hold this one. I believe that using multiple |
I test all the Casks I submit from my production setup (
|
That's good to know, and reveals a bug. What was broken until #3217 was the form uninstall :pkgutil => [
'com.Aliph.jawbone.pkg',
'com.Aliph.JawboneUpdater.pkg',
'com.Aliph.jawboneUpdater.preflight.pkg',
'com.Aliph.jawboneUpdater.postflight.pkg',
] The bug is: the DSL treats However, the When there are multiple Since you only use the same operation |
To find the packages matching a regexp, you can do I suspect that what tripped you up with this regexp was the "J" being in both upper and lower case. This form worked for me: uninstall :pkgutil => 'com.Aliph.[Jj]awbone(|Updater.*).pkg' I suppose we should start anchoring those regexps with |
In Homebrew#3431, we recently discovered that this form is valid to the DSL, but can exercise a bug at uninstall time.
Inspired by @alebcay in Homebrew#3431 .
Add uninstall stanza for Jawbone Updater
Uninstalls four packages from the system. I attempted to use regular expressions, but they weren't working, so I hard-coded it.