Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync uart and flash for wba #453

Merged
merged 4 commits into from
Nov 18, 2024
Merged

fix: sync uart and flash for wba #453

merged 4 commits into from
Nov 18, 2024

Conversation

andjordan
Copy link
Contributor

@andjordan andjordan commented Nov 15, 2024

  • Fix RX UART interrupt not being enabled
  • Fix write to flash for larger payloads
  • Fix flash erase for dual bank

Copy link
Contributor

github-actions bot commented Nov 15, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 6 0 0.05s
✅ CPP clang-format 14 3 0 0.25s
✅ DOCKERFILE hadolint 1 0 0.14s
✅ JSON jsonlint 7 0 0.2s
✅ JSON prettier 7 2 0 0.59s
⚠️ MARKDOWN markdownlint 6 1 7 0.86s
⚠️ MARKDOWN markdown-link-check 6 2 44.54s
✅ MARKDOWN markdown-table-formatter 6 1 0 0.23s
✅ REPOSITORY checkov yes no 24.93s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY grype yes no 8.91s
✅ REPOSITORY ls-lint yes no 0.06s
✅ REPOSITORY secretlint yes no 34.7s
✅ REPOSITORY trivy yes no 12.03s
✅ REPOSITORY trivy-sbom yes no 0.1s
✅ REPOSITORY trufflehog yes no 10.04s
⚠️ SPELL lychee 32 1 87.1s
✅ YAML prettier 9 1 0 0.65s
✅ YAML v8r 9 0 5.87s
✅ YAML yamllint 9 0 0.37s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@andjordan andjordan changed the title fix: receive on sync uart fix: sync uart and flash for wba Nov 15, 2024
@andjordan andjordan marked this pull request as ready for review November 15, 2024 16:50
@andjordan andjordan requested a review from a team as a code owner November 15, 2024 16:50
@fabiangottstein
Copy link
Contributor

It looks like the implementation of FlashInternalStm and SynchronousFlashInternalStm is exactly the same (besides the bank handling while erasing).
Maybe we should extract the implementation details in a future PR to avoid these code duplications ?
What do you think @richardapeters ?

@richardapeters
Copy link
Collaborator

Yes, it seems to make sense that FlashInternalStm would use SynchronousFlashInternalStm, and adds a callback, since FlashInternalStm is basically synchronous as well.

@andjordan andjordan enabled auto-merge (squash) November 18, 2024 13:30
@andjordan andjordan merged commit feb8b53 into main Nov 18, 2024
24 checks passed
@andjordan andjordan deleted the feature/wba_fixes branch November 18, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants