-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Remove FIFO queues #4072
Merged
Merged
fix!: Remove FIFO queues #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
force-pushed
the
npalm/fix/fifo
branch
from
December 20, 2024 09:29
daf1d07
to
157889f
Compare
mpas
previously approved these changes
Dec 20, 2024
npalm
pushed a commit
that referenced
this pull request
Dec 20, 2024
🤖 I have created a release *beep* *boop* --- ## [6.0.0](v5.21.0...v6.0.0) (2024-12-20) This release contains several breaking changes - Terraform AWS provider minimal version is upgraded to support node 22 - EventBridge is used by default, opt out can be configured - FIFO queued are removed, an update will re-crate all queues. This can cause loss of messages. When the EventBridge is enabled messages can be replayed if needed. - Deprecated variables are removed ### ⚠ BREAKING CHANGES * Enable eventbridge by default ([#4320](#4320)) * remove deprecated metric feature flag ([#4319](#4319)) * Upgrade Node to 22 (LTS) ([#4318](#4318)) * remove deprecated variables ([#4073](#4073)) * Remove FIFO queues ([#4072](#4072)) * remove deprecated runners_scale_up_Lambda_memory_size as it breaks CDKTF ([#4276](#4276)) ### Features * Enable eventbridge by default ([#4320](#4320)) ([142bb61](142bb61)) * Upgrade Node to 22 (LTS) ([#4318](#4318)) ([c5d4693](c5d4693)) ### Bug Fixes * broken docs after removing examples ([#4321](#4321)) ([7171215](7171215)) * remove deprecated metric feature flag ([#4319](#4319)) ([70105b4](70105b4)) * remove deprecated runners_scale_up_Lambda_memory_size as it breaks CDKTF ([#4276](#4276)) ([a2280f7](a2280f7)) * remove deprecated variables ([#4073](#4073)) ([099c78d](099c78d)) * Remove FIFO queues ([#4072](#4072)) ([2f20a8b](2f20a8b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes FIFO queues as described in #4068
Breaking
The change will re-create queues in case FIFO is configured. Impact will be that queued messages are lost
Test