Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove FIFO queues #4072

Merged
merged 12 commits into from
Dec 20, 2024
Merged

fix!: Remove FIFO queues #4072

merged 12 commits into from
Dec 20, 2024

Conversation

npalm
Copy link
Member

@npalm npalm commented Aug 16, 2024

Description

Removes FIFO queues as described in #4068

Breaking

The change will re-create queues in case FIFO is configured. Impact will be that queued messages are lost

Test

  • default example
  • multi runner example

@npalm npalm requested review from stuartp44 and Brend-Smits August 16, 2024 11:04
@npalm npalm changed the title !fix: Remove FIFO queues fix!: Remove FIFO queues Aug 16, 2024
@npalm npalm marked this pull request as draft October 8, 2024 07:51
@npalm npalm requested a review from mpas December 20, 2024 09:30
@npalm npalm marked this pull request as ready for review December 20, 2024 09:33
mpas
mpas previously approved these changes Dec 20, 2024
@npalm npalm merged commit 2f20a8b into main Dec 20, 2024
1 check passed
@npalm npalm deleted the npalm/fix/fifo branch December 20, 2024 13:13
npalm pushed a commit that referenced this pull request Dec 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](v5.21.0...v6.0.0)
(2024-12-20)

This release contains several breaking changes

- Terraform AWS provider minimal version is upgraded to support node 22
- EventBridge is used by default, opt out can be configured
- FIFO queued are removed, an update will re-crate all queues. This can
cause loss of messages. When the EventBridge is enabled messages can be
replayed if needed.
- Deprecated variables are removed


### ⚠ BREAKING CHANGES

* Enable eventbridge by default
([#4320](#4320))
* remove deprecated metric feature flag
([#4319](#4319))
* Upgrade Node to 22 (LTS)
([#4318](#4318))
* remove deprecated variables
([#4073](#4073))
* Remove FIFO queues
([#4072](#4072))
* remove deprecated runners_scale_up_Lambda_memory_size as it breaks
CDKTF
([#4276](#4276))

### Features

* Enable eventbridge by default
([#4320](#4320))
([142bb61](142bb61))
* Upgrade Node to 22 (LTS)
([#4318](#4318))
([c5d4693](c5d4693))


### Bug Fixes

* broken docs after removing examples
([#4321](#4321))
([7171215](7171215))
* remove deprecated metric feature flag
([#4319](#4319))
([70105b4](70105b4))
* remove deprecated runners_scale_up_Lambda_memory_size as it breaks
CDKTF
([#4276](#4276))
([a2280f7](a2280f7))
* remove deprecated variables
([#4073](#4073))
([099c78d](099c78d))
* Remove FIFO queues
([#4072](#4072))
([2f20a8b](2f20a8b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants