From 6962b5fdd0279d86971b7d2c6b92c2274eb93f19 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 13 Nov 2023 10:09:13 -0800 Subject: [PATCH] Move test_windows under test_JS (#41455) Summary: CircleCI was broken since Friday because a change broke JS tests on Windows only. The test_windows job didn't run on those changes because they were JS changes only, therefore won't affect the build of React Native on Windows. The `test_windows` was listed among the various `test_android` jobs, but it is not actually building React Native android on windows machines. Instead, the test_windows jobs is actually only running JS tests on a windows machines. Therefore, it makes more sense to have this test under the test_js group. bypass-github-export-checks ## Changelog: [Internal] - Move the test_windows job under the testJS configuration Pull Request resolved: https://github.com/facebook/react-native/pull/41455 Test Plan: CircleCI is green. test_windows run together with the JS tests Reviewed By: mdvacca Differential Revision: D51258120 Pulled By: cipolleschi fbshipit-source-id: a523c48f697b64620433ec9672f13baa308d75a8 --- .circleci/configurations/test_workflows/testAll.yml | 1 - .circleci/configurations/test_workflows/testAndroid.yml | 1 - .circleci/configurations/test_workflows/testJS.yml | 1 + 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.circleci/configurations/test_workflows/testAll.yml b/.circleci/configurations/test_workflows/testAll.yml index 49d69da22c7781..71841f302f70be 100644 --- a/.circleci/configurations/test_workflows/testAll.yml +++ b/.circleci/configurations/test_workflows/testAll.yml @@ -115,4 +115,3 @@ matrix: parameters: jsengine: ["Hermes", "JSC"] - - test_windows diff --git a/.circleci/configurations/test_workflows/testAndroid.yml b/.circleci/configurations/test_workflows/testAndroid.yml index fd78d2f1f52a40..b91cf2ac2d3ede 100644 --- a/.circleci/configurations/test_workflows/testAndroid.yml +++ b/.circleci/configurations/test_workflows/testAndroid.yml @@ -55,4 +55,3 @@ architecture: ["NewArch", "OldArch"] jsengine: ["Hermes", "JSC"] flavor: ["Debug", "Release"] - - test_windows diff --git a/.circleci/configurations/test_workflows/testJS.yml b/.circleci/configurations/test_workflows/testJS.yml index 0c381150c17966..38b61d58734932 100644 --- a/.circleci/configurations/test_workflows/testJS.yml +++ b/.circleci/configurations/test_workflows/testJS.yml @@ -10,3 +10,4 @@ - test_js: name: test_js_prev_lts executor: nodeprevlts + - test_windows